-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: ignore node_modules when using vsce for bundling #170
Conversation
@sdankel friendly pin, could you please have a look? |
@bethatguyad thank you for the contribution! However, I'm pretty sure the dependencies need to be part of the bundle for it to work properly. I'll test this out today. https://code.visualstudio.com/api/working-with-extensions/publishing-extension#using-.vscodeignore We should be ignoring .ts files, as the docs suggest, if you'd like to make that change. |
When I tested it, the plugin does not work without |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Happy to approve once my comments are addressed. This seems to make the extension run much faster 🔥
Co-authored-by: Sophie Dankel <47993817+sdankel@users.noreply.github.com>
* chore: ignore node_modules when using vsce for bundling * feat: 🎸 use esbuild instead * Update .vscodeignore Co-authored-by: Sophie Dankel <47993817+sdankel@users.noreply.github.com> * fix: 🐛 address issue * chore: update docs * Update client/src/client.ts --------- Co-authored-by: Sophie Dankel <47993817+sdankel@users.noreply.github.com>
Closed #160