Allow overriding the path to forc-lsp executable #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #167 By default the field is empty and it is only useful to advanced users. The runtime will use the field to try to boot the lsp but in case the configuration is invalid it will fallback to finding the forc-lsp in $PATH
JoshuaBatty
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Nice one thanks Sophie. We should cut a release after this is merged.
Pinging @luizstacio as he originally requested this feature :)
sdankel
added a commit
that referenced
this pull request
Apr 17, 2024
* Add configuration to let users select their forc-lsp Fixes #167 By default the field is empty and it is only useful to advanced users. The runtime will use the field to try to boot the lsp but in case the configuration is invalid it will fallback to finding the forc-lsp in $PATH * Allow overriding the path to forc-lsp executable * prettier * update reload opts * fix typo --------- Co-authored-by: Cesar Rodas <cesar@rodasm.com.py>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #167