Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add option to disable LSP #180

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Apr 18, 2024

Some users with very large projects are having issues with LSP. This option will let them disable it while still getting syntax highlighting and debugging.

image

image

@sdankel sdankel changed the title Add option to disable LSP chore: Add option to disable LSP Apr 18, 2024
@sdankel sdankel marked this pull request as ready for review April 18, 2024 17:16
@github-actions github-actions bot added the chore label Apr 18, 2024
Copy link
Member

@JoshuaBatty JoshuaBatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Sophie. Tested locally and works as expected.

@JoshuaBatty JoshuaBatty merged commit 942a832 into master Apr 18, 2024
5 of 7 checks passed
@JoshuaBatty JoshuaBatty deleted the sophie/disable-option branch April 18, 2024 23:33
JoshuaBatty added a commit to FuelLabs/sway that referenced this pull request Apr 18, 2024
## Description

To be merged after
FuelLabs/sway-vscode-plugin#180

## Checklist

- [ ] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [ ] I have requested a review from the relevant team or maintainers.

---------

Co-authored-by: Joshua Batty <joshpbatty@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants