Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Info message when LSP is out of date #188

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Jul 1, 2024

Related FuelLabs/sway#5280

Adds a custom key to the package.json indicating the latest version of forc-lsp at the time of the plugin's release. If the user's version of forc-lsp is older than that, they will see an info message.

image

@github-actions github-actions bot added the feat label Jul 1, 2024
@sdankel sdankel requested a review from a team July 1, 2024 22:07
kayagokalp
kayagokalp previously approved these changes Aug 18, 2024
@sdankel
Copy link
Member Author

sdankel commented Aug 20, 2024

@JoshuaBatty What do you think about this? I remember you had some objections.

@JoshuaBatty
Copy link
Member

I'm just worried there might be a situation where users are on a stable mainnet version of forc-lsp that might be behind the latest bleeding edge release. In this instance they might get this message shown to them every session which might be annoying.

@sdankel
Copy link
Member Author

sdankel commented Aug 22, 2024

I'm just worried there might be a situation where users are on a stable mainnet version of forc-lsp that might be behind the latest bleeding edge release. In this instance they might get this message shown to them every session which might be annoying.

That's a fair concern. We would have control over it though, as we manually set the minimum version to not receive the warning in the latestForcVersion field in package.json. So, we could set it only update it to the latest mainnet version.

@JoshuaBatty
Copy link
Member

I'm just worried there might be a situation where users are on a stable mainnet version of forc-lsp that might be behind the latest bleeding edge release. In this instance they might get this message shown to them every session which might be annoying.

That's a fair concern. We would have control over it though, as we manually set the minimum version to not receive the warning in the latestForcVersion field in package.json. So, we could set it only update it to the latest mainnet version.

Cool, makes sense. I'm happy for this to merge then.

package.json Outdated Show resolved Hide resolved
Co-authored-by: Joshua Batty <joshpbatty@gmail.com>
@JoshuaBatty JoshuaBatty merged commit 050d092 into master Aug 22, 2024
5 checks passed
@JoshuaBatty JoshuaBatty deleted the sophie/newVersionForc branch August 22, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants