Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forc-client should support signing transactions using a KMS #6560

Closed
kayagokalp opened this issue Sep 18, 2024 · 1 comment · Fixed by #6578
Closed

forc-client should support signing transactions using a KMS #6560

kayagokalp opened this issue Sep 18, 2024 · 1 comment · Fixed by #6578
Assignees
@kayagokalp
Labels
enhancement New feature or request forc-client Everything related to the `forc-client` crate. P: critical Should be looked at before anything else

Comments

@kayagokalp
Copy link
Member

blocked by #6559

We need to implement a KMS signer for forc-client, specifically we can start with AWS KMS solution. This will allow us sign transactions using through KMS rather than local keys for more "shared" and "secure" deployment workflows.
@kayagokalp kayagokalp added enhancement New feature or request P: critical Should be looked at before anything else forc-client Everything related to the `forc-client` crate. labels Sep 18, 2024
@kayagokalp kayagokalp self-assigned this Sep 18, 2024
@kayagokalp
Copy link
Member Author

The rough design is the following:

  1. Check cli options to see if the user wants to use a local signer or a KMS one (at this stage if the user provided an arn the signer is a aws kms right away)
    2-a. If it is local one, we will guide them through all the same workflow
    3-a. If it is aws KMS one, we will use the AWS KMS arn, and basically use the upcoming AwsKmsSigner which implements Signer from rust-sdk, instead of WalletUnlocked which we use by default right now in forc-client

This was referenced Sep 22, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kayagokalp kayagokalp

Labels
enhancement New feature or request forc-client Everything related to the `forc-client` crate. P: critical Should be looked at before anything else
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: AWS kms signer support for forc-client FuelLabs/sway
1 participant
@kayagokalp