feat: AWS kms signer support for forc-client #6578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayagokalp
added
enhancement
kayagokalp
changed the title
alfiedotwtf
reviewed
Sep 23, 2024
|
Looks like we hit a flaky test (hopefully, as it was not failing in previous commit and now it is failing): #5376 (comment) |
alfiedotwtf
reviewed
Sep 23, 2024
alfiedotwtf
previously approved these changes
Sep 23, 2024
Merged
JoshuaBatty
reviewed
Sep 24, 2024
JoshuaBatty
reviewed
Sep 24, 2024
|
Is this entirely additive or does it include breaking behavior? |
This is entirely additive, |
kayagokalp
commented
Sep 24, 2024
kayagokalp
commented
Sep 24, 2024
alfiedotwtf
reviewed
Sep 24, 2024
alfiedotwtf
previously requested changes
Sep 24, 2024
kayagokalp
commented
Sep 24, 2024
JoshuaBatty
approved these changes
Sep 25, 2024
IGI-111
pushed a commit
that referenced
this pull request
Sep 25, 2024
## Description ~~waiting on #6578~~ This release contains no API changes and along with bug fixes, upgrades support for fuel-core to 0.36 and fuels SDK to 0.66.5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #6560.
closes #6559.
This PR adds AWS kms signer support. Which is enabled if
--aws-kms-signer <ARN>is present. If that is the case, an aws client is created which is used to create a AwsSigner.With this PR, we are able to supply a signing arn and with that we can sign a transaction. This enables being able to revoke signing authority for aws kms managed keys. So we can control deployments and owner/target changes for a proxy contract. Effectively enabling multi-sig like proxy contracts via aws kms.