Attempt to workaround unused-deps CI error by updating mdbook to 0.4.20 and applying upstream patch #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm doesn't seem to be fixed by updating the mdbook version. |
|
Can confirm building |
mitchmindtree
changed the title
|
OK, I worked out a fix upstream, see here rust-lang/mdBook#1861. This PR applies the above mdbook patch to work around this rustc nightly breakage. I've opened an issue at the rust repo to keep track rust-lang/rust#99591. Once we land this, I'll open an issue about removing the patch so we don't forget. |
JoshuaBatty
approved these changes
Jul 22, 2022
mitchmindtree
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unused deps CI check has started failing on unrelated PRs recently, e.g. #2359 (comment).
Seeing if updating mdbook addresses nightly-Rust's new borrow-check concerns.