-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes method application argument type checking. #5632
Merged
esdrubal
merged 2 commits into
master
from
esdrubal/5614_method_application_parameters_annotation_fix
Feb 20, 2024
Merged
Fixes method application argument type checking. #5632
esdrubal
merged 2 commits into
master
from
esdrubal/5614_method_application_parameters_annotation_fix
Feb 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While doing the argument type checking we set the type annotation to Unknown because the method has not been resolved yet. With this change when we fail to type check an argument expression with the annotation Unknown we try again after resolving the method name. The reason we do the double pass on argument type checking is because we need the types from the arguments to resolve the method but sometimes we need the method resolved for resolving the argument expressions with the type parameters.
esdrubal
added
the
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
label
Feb 19, 2024
Benchmark for 4eda799Click to view benchmark
|
IGI-111
approved these changes
Feb 19, 2024
JoshuaBatty
approved these changes
Feb 19, 2024
Benchmark for f17d874Click to view benchmark
|
esdrubal
deleted the
esdrubal/5614_method_application_parameters_annotation_fix
branch
February 20, 2024 07:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While doing the argument type checking we set the type annotation to Unknown because the method has not been resolved yet.
With this change when we fail to type check an argument expression with the annotation Unknown we try again after resolving the method name.
The reason we do the double pass on argument type checking is because we need the types from the arguments to resolve the method but sometimes we need the method resolved for resolving the argument expressions with the type parameters.
Fixes #5614
Checklist
Breaking*
orNew Feature
labels where relevant.