Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use fuels-rs v0.62.0, fuel-abi-types v0.5.0 #6027

Merged
merged 5 commits into from
May 17, 2024

Conversation

kayagokalp
Copy link
Member

Description

Bumps:

  1. fuels-rs v0.62.0
  2. forc-wallet to v0.7.1
  3. fuels-abi-types to v0.5.0

In the process I had to adjust forc-run to use new encoding api from the sdk as well.

Copy link

Benchmark for 70d0380

Click to view benchmark
Test Base PR %
code_action 5.2±0.11ms 5.3±0.15ms +1.92%
code_lens 283.5±9.39ns 281.9±7.45ns -0.56%
compile 3.0±0.04s 2.9±0.02s -3.33%
completion 4.5±0.02ms 4.6±0.02ms +2.22%
did_change_with_caching 2.8±0.03s 2.8±0.03s 0.00%
document_symbol 949.3±21.49µs 950.4±23.52µs +0.12%
format 70.1±0.92ms 84.3±1.30ms +20.26%
goto_definition 357.9±5.65µs 358.4±6.13µs +0.14%
highlight 8.7±0.03ms 9.0±0.20ms +3.45%
hover 480.9±6.44µs 485.0±6.74µs +0.85%
idents_at_position 123.4±0.49µs 121.8±0.95µs -1.30%
inlay_hints 645.7±11.73µs 648.8±23.86µs +0.48%
on_enter 455.0±4.61ns 482.4±18.55ns +6.02%
parent_decl_at_position 3.6±0.03ms 3.6±0.04ms 0.00%
prepare_rename 354.0±4.61µs 359.5±8.55µs +1.55%
rename 9.2±0.15ms 9.5±0.07ms +3.26%
semantic_tokens 971.4±16.17µs 955.0±23.82µs -1.69%
token_at_position 359.2±2.44µs 354.8±3.69µs -1.22%
tokens_at_position 3.6±0.04ms 3.6±0.05ms 0.00%
tokens_for_file 420.2±2.85µs 416.1±1.66µs -0.98%
traverse 40.6±0.90ms 41.6±1.37ms +2.46%

@kayagokalp kayagokalp self-assigned this May 17, 2024
@kayagokalp kayagokalp requested review from Voxelot and a team May 17, 2024 00:19
@kayagokalp
Copy link
Member Author

This unblocks #5980

@kayagokalp kayagokalp enabled auto-merge (squash) May 17, 2024 00:21
JoshuaBatty
JoshuaBatty previously approved these changes May 17, 2024
@JoshuaBatty JoshuaBatty requested review from a team May 17, 2024 00:33
@JoshuaBatty JoshuaBatty requested review from a team May 17, 2024 00:40
@kayagokalp
Copy link
Member Author

https://github.com/FuelLabs/sway/actions/runs/9120912385/job/25079218484?pr=6027 -- --update-output-files flag is very handy but it only updates a specific profile.. So in the linked run running sway in release mode has some failing tests. This should either be documented in the help message or the behaviour should change to updating all outputs for all profiles.

opened #6028

@kayagokalp kayagokalp merged commit 0f1bdef into master May 17, 2024
38 checks passed
@kayagokalp kayagokalp deleted the kayagokalp/sdk-0.62 branch May 17, 2024 01:02
Copy link

Benchmark for ccfa284

Click to view benchmark
Test Base PR %
code_action 5.4±0.04ms 5.4±0.13ms 0.00%
code_lens 283.1±10.84ns 295.2±9.24ns +4.27%
compile 2.9±0.05s 2.9±0.05s 0.00%
completion 4.7±0.08ms 4.7±0.04ms 0.00%
did_change_with_caching 2.8±0.02s 2.7±0.05s -3.57%
document_symbol 985.5±19.22µs 956.4±19.48µs -2.95%
format 70.1±0.72ms 84.7±1.70ms +20.83%
goto_definition 367.8±6.20µs 364.3±4.00µs -0.95%
highlight 9.0±0.30ms 9.1±0.10ms +1.11%
hover 481.1±5.83µs 489.6±16.51µs +1.77%
idents_at_position 122.9±0.32µs 122.0±0.60µs -0.73%
inlay_hints 666.3±20.39µs 666.6±9.36µs +0.05%
on_enter 474.8±13.14ns 480.8±16.82ns +1.26%
parent_decl_at_position 3.7±0.02ms 3.8±0.02ms +2.70%
prepare_rename 368.4±5.32µs 364.9±6.20µs -0.95%
rename 9.6±0.12ms 9.6±0.02ms 0.00%
semantic_tokens 1000.6±13.89µs 956.2±13.42µs -4.44%
token_at_position 372.7±3.05µs 358.5±2.69µs -3.81%
tokens_at_position 3.7±0.05ms 3.8±0.02ms +2.70%
tokens_for_file 428.1±2.40µs 604.6±4.80µs +41.23%
traverse 40.4±1.08ms 39.7±1.00ms -1.73%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants