Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump fuel-core to v0.27.0 #6090

Merged
merged 8 commits into from
Jun 6, 2024
Merged

chore: bump fuel-core to v0.27.0 #6090

merged 8 commits into from
Jun 6, 2024

Conversation

kayagokalp
Copy link
Member

@kayagokalp kayagokalp commented Jun 4, 2024 •
edited
Loading

Description

Updates sdk used to v0.63.0 also updates fuel-core to v0.27.0 and forc-wallet to v0.8.0.

@kayagokalp kayagokalp self-assigned this Jun 4, 2024
@kayagokalp kayagokalp marked this pull request as ready for review June 4, 2024 22:20
@kayagokalp kayagokalp requested a review from a team as a code owner June 4, 2024 22:20
@kayagokalp kayagokalp enabled auto-merge (squash) June 4, 2024 22:20
@kayagokalp kayagokalp requested review from a team June 4, 2024 22:20
@sdankel sdankel mentioned this pull request Jun 4, 2024
Open
@kayagokalp kayagokalp force-pushed the kayagokalp/bump-fuel-core-v0.27.0 branch from 01ade05 to ffb2211 Compare June 5, 2024 20:51
@kayagokalp kayagokalp linked an issue Jun 5, 2024 that may be closed by this pull request
Use fuel-core v0.27.0 #6083
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Benchmark for 3e6a9bb

Click to view benchmark
Test Base PR %
code_action 5.5±0.16ms 5.4±0.23ms -1.82%
code_lens 339.8±13.80ns 294.2±11.54ns -13.42%
compile 5.1±0.37s 5.4±0.28s +5.88%
completion 4.9±0.22ms 4.8±0.25ms -2.04%
did_change_with_caching 5.0±0.20s 4.6±0.14s -8.00%
document_symbol 986.1±25.49µs 1047.7±90.92µs +6.25%
format 76.5±1.85ms 74.7±2.14ms -2.35%
goto_definition 372.9±10.08µs 368.4±9.55µs -1.21%
highlight 9.1±0.30ms 8.8±0.31ms -3.30%
hover 622.5±6.82µs 547.0±9.43µs -12.13%
idents_at_position 127.9±2.93µs 129.2±1.93µs +1.02%
inlay_hints 675.6±24.14µs 667.9±35.78µs -1.14%
on_enter 460.0±29.43ns 486.1±10.80ns +5.67%
parent_decl_at_position 3.8±0.06ms 3.6±0.06ms -5.26%
prepare_rename 369.6±9.10µs 366.5±9.17µs -0.84%
rename 9.8±0.34ms 9.6±0.49ms -2.04%
semantic_tokens 1010.8±28.99µs 992.9±22.38µs -1.77%
token_at_position 368.0±5.40µs 361.2±5.37µs -1.85%
tokens_at_position 3.7±0.04ms 3.6±0.05ms -2.70%
tokens_for_file 435.5±3.35µs 424.9±3.23µs -2.43%
traverse 56.5±1.81ms 58.7±2.08ms +3.89%

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Benchmark for e096f7d

Click to view benchmark
Test Base PR %
code_action 5.4±0.21ms 5.3±0.02ms -1.85%
code_lens 336.3±14.86ns 288.5±6.16ns -14.21%
compile 4.1±0.09s 4.0±0.04s -2.44%
completion 4.8±0.14ms 4.6±0.12ms -4.17%
did_change_with_caching 3.8±0.10s 3.7±0.09s -2.63%
document_symbol 995.4±44.67µs 948.3±8.67µs -4.73%
format 74.4±0.69ms 70.7±0.83ms -4.97%
goto_definition 375.0±3.49µs 363.3±3.59µs -3.12%
highlight 9.0±0.24ms 8.7±0.23ms -3.33%
hover 552.5±6.41µs 542.8±16.55µs -1.76%
idents_at_position 122.5±0.45µs 123.9±2.52µs +1.14%
inlay_hints 676.8±43.99µs 648.2±10.74µs -4.23%
on_enter 462.8±23.28ns 461.7±12.56ns -0.24%
parent_decl_at_position 3.7±0.05ms 3.6±0.02ms -2.70%
prepare_rename 375.7±15.08µs 366.8±8.32µs -2.37%
rename 9.6±0.34ms 9.3±0.34ms -3.12%
semantic_tokens 984.1±14.76µs 979.1±24.23µs -0.51%
token_at_position 359.4±4.47µs 362.1±2.35µs +0.75%
tokens_at_position 3.7±0.01ms 3.6±0.03ms -2.70%
tokens_for_file 427.9±3.82µs 425.1±2.54µs -0.65%
traverse 40.3±1.20ms 40.4±1.04ms +0.25%

sdankel
sdankel previously approved these changes Jun 6, 2024
View reviewed changes
@kayagokalp @sdankel
Update mod.rs
992bfdd 
Co-authored-by: Sophie Dankel <47993817+sdankel@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

Benchmark for e9b2104

Click to view benchmark
Test Base PR %
code_action 5.2±0.13ms 5.2±0.07ms 0.00%
code_lens 330.1±16.52ns 285.8±6.24ns -13.42%
compile 3.9±0.10s 3.9±0.09s 0.00%
completion 4.7±0.05ms 4.6±0.15ms -2.13%
did_change_with_caching 3.6±0.09s 3.6±0.11s 0.00%
document_symbol 973.3±30.83µs 949.0±19.88µs -2.50%
format 71.6±1.17ms 70.4±2.34ms -1.68%
goto_definition 362.6±6.27µs 367.7±9.50µs +1.41%
highlight 8.9±0.20ms 8.7±0.43ms -2.25%
hover 531.3±4.83µs 536.3±10.15µs +0.94%
idents_at_position 122.0±1.99µs 124.2±0.46µs +1.80%
inlay_hints 655.9±23.09µs 651.2±22.96µs -0.72%
on_enter 456.9±10.25ns 474.0±20.55ns +3.74%
parent_decl_at_position 3.7±0.06ms 3.6±0.07ms -2.70%
prepare_rename 355.4±12.18µs 363.8±12.37µs +2.36%
rename 9.5±0.07ms 9.2±0.16ms -3.16%
semantic_tokens 965.2±15.91µs 985.3±28.76µs +2.08%
token_at_position 351.4±7.36µs 360.6±2.85µs +2.62%
tokens_at_position 3.7±0.06ms 3.6±0.04ms -2.70%
tokens_for_file 423.6±7.90µs 412.5±3.34µs -2.62%
traverse 38.6±1.40ms 38.7±1.47ms +0.26%

sdankel
sdankel previously approved these changes Jun 6, 2024
View reviewed changes
Voxelot
Voxelot previously approved these changes Jun 6, 2024
View reviewed changes
@kayagokalp kayagokalp dismissed stale reviews from Voxelot and sdankel via 842bbb9 June 6, 2024 21:48
@kayagokalp kayagokalp requested a review from xunilrj June 6, 2024 21:48
@kayagokalp kayagokalp requested review from Voxelot, sdankel and a team June 6, 2024 21:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

Benchmark for e6b41a9

Click to view benchmark
Test Base PR %
code_action 5.5±0.12ms 5.3±0.11ms -3.64%
code_lens 338.0±10.21ns 293.7±28.82ns -13.11%
compile 4.2±0.06s 4.1±0.14s -2.38%
completion 4.8±0.54ms 4.7±0.38ms -2.08%
did_change_with_caching 3.9±0.13s 3.7±0.04s -5.13%
document_symbol 952.3±12.82µs 999.5±23.70µs +4.96%
format 76.0±0.86ms 71.2±0.69ms -6.32%
goto_definition 361.6±4.21µs 366.4±5.75µs +1.33%
highlight 9.0±0.21ms 8.7±0.24ms -3.33%
hover 534.8±8.31µs 545.2±6.65µs +1.94%
idents_at_position 124.4±0.41µs 123.0±1.58µs -1.13%
inlay_hints 656.5±11.83µs 655.5±21.67µs -0.15%
on_enter 458.0±16.52ns 475.2±9.87ns +3.76%
parent_decl_at_position 3.7±0.02ms 3.6±0.04ms -2.70%
prepare_rename 360.0±5.52µs 366.5±5.31µs +1.81%
rename 9.6±0.18ms 9.3±0.37ms -3.12%
semantic_tokens 977.7±27.87µs 975.6±28.29µs -0.21%
token_at_position 363.7±1.81µs 356.6±2.87µs -1.95%
tokens_at_position 3.7±0.03ms 3.6±0.05ms -2.70%
tokens_for_file 433.0±2.91µs 436.6±6.78µs +0.83%
traverse 41.5±1.79ms 41.4±1.63ms -0.24%

@kayagokalp kayagokalp merged commit d102972 into master Jun 6, 2024
38 checks passed
@kayagokalp kayagokalp deleted the kayagokalp/bump-fuel-core-v0.27.0 branch June 6, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xunilrj xunilrj xunilrj approved these changes

@Voxelot Voxelot Voxelot approved these changes

@IGI-111 IGI-111 IGI-111 approved these changes

@sdankel sdankel sdankel approved these changes

Assignees

@kayagokalp kayagokalp

Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use fuel-core v0.27.0
5 participants
@kayagokalp @xunilrj @Voxelot @IGI-111 @sdankel