Add tracing span macro calls to the language server for better debugging #6238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for a2ed695Click to view benchmark
|
JoshuaBatty
force-pushed
the
josh/lsp_tracing_spans
branch
from
8544b08 to
9215b58
Compare
Benchmark for 77cb7d5Click to view benchmark
|
JoshuaBatty
force-pushed
the
josh/lsp_tracing_spans
branch
from
ef28f0d to
4461ad3
Compare
Benchmark for 0ab0fc9Click to view benchmark
|
kayagokalp
reviewed
Jul 9, 2024
There was a problem hiding this comment.
Generally we seem to be trying to catch function spans. I think #[instrument] will already do that and might be cleaner if you prefer it: https://docs.rs/tracing/latest/tracing/attr.instrument.html, otherwise happy to approve
Yeah nice, can see how this would be handy in certain situations. I'll probably prefer to stick with this current approach for now though. Thanks for sharing though! |
kayagokalp
approved these changes
Jul 10, 2024
Benchmark for 206b2adClick to view benchmark
|
Benchmark for 5bbf20aClick to view benchmark
|
Benchmark for e828064Click to view benchmark
|
IGI-111
approved these changes
Jul 15, 2024
esdrubal
pushed a commit
that referenced
this pull request
Aug 13, 2024
…ing (#6238) ## Description closes #6220 ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #6220
Checklist
Breaking*orNew Featurelabels where relevant.