Implement a map from typed to parsed decl ids in the declaration engine. #6245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tritao
added
compiler: frontend
tritao
force-pushed
the
decl-engine-parsed-decl-id-map
branch
2 times, most recently
from
3e942ec to
235a37b
Compare
8 tasks
IGI-111
pushed a commit
that referenced
this pull request
Jul 10, 2024
…6251) ## Description This PR unifies the AST representation for the parsed and typed `impl self` and `impl trait` declarations. Previously we had a parsed node for `impl self`, which was converted into a `impl trait` typed node. Now we are doing the same for the parsed nodes and using a unified `ImplSelfOrTrait` node. This will make it possible for #6245 to store the parsed decl id relationship for this node. ## Checklist - [x] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
tritao
force-pushed
the
decl-engine-parsed-decl-id-map
branch
from
235a37b to
7ab6b89
Compare
tritao
force-pushed
the
decl-engine-parsed-decl-id-map
branch
from
7ab6b89 to
d3dff0d
Compare
JoshuaBatty
reviewed
Jul 10, 2024
IGI-111
approved these changes
Jul 12, 2024
esdrubal
pushed a commit
that referenced
this pull request
Aug 13, 2024
…6251) ## Description This PR unifies the AST representation for the parsed and typed `impl self` and `impl trait` declarations. Previously we had a parsed node for `impl self`, which was converted into a `impl trait` typed node. Now we are doing the same for the parsed nodes and using a unified `ImplSelfOrTrait` node. This will make it possible for #6245 to store the parsed decl id relationship for this node. ## Checklist - [x] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
esdrubal
pushed a commit
that referenced
this pull request
Aug 13, 2024
…ne. (#6245) ## Description Implements a map from typed to parsed decl ids in the declaration engine. ## Checklist - [x] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers. --------- Co-authored-by: IGI-111 <igi-111@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements a map from typed to parsed decl ids in the declaration engine.
Checklist
Breaking*orNew Featurelabels where relevant.