Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uncomment update contract update check #6247

Merged
merged 6 commits into from
Jul 10, 2024

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Jul 9, 2024

Description

  • Uncomment clean git status
  • allow interactive update with the -i flag.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj requested a review from a team as a code owner July 9, 2024 08:01
JoshuaBatty
JoshuaBatty previously approved these changes Jul 9, 2024
@JoshuaBatty JoshuaBatty requested review from a team July 9, 2024 09:46
test/update-contract-ids.sh Outdated Show resolved Hide resolved
test/update-contract-ids.sh Outdated Show resolved Hide resolved
@xunilrj xunilrj requested review from IGI-111 and JoshuaBatty July 9, 2024 18:39
Copy link
Contributor

@IGI-111 IGI-111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IGI-111 IGI-111 requested a review from a team July 9, 2024 22:36
@IGI-111 IGI-111 merged commit cbcb2f0 into master Jul 10, 2024
38 checks passed
@IGI-111 IGI-111 deleted the xunilrj/uncomment-update-contract-check branch July 10, 2024 05:20
esdrubal pushed a commit that referenced this pull request Aug 13, 2024
## Description

- Uncomment clean git status
- allow interactive update with the `-i` flag.

## Checklist

- [ ] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [ ] I have requested a review from the relevant team or maintainers.

---------

Co-authored-by: IGI-111 <igi-111@protonmail.com>
Co-authored-by: Joshua Batty <joshpbatty@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants