Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Transaction::Upload, Transaction::Upgrade, and Transaction::Blob #6500

Merged
merged 18 commits into from
Sep 11, 2024

Conversation

bitzoic
Copy link
Member

@bitzoic bitzoic commented Sep 5, 2024

Description

The current Transaction enum in the tx library does not support the new transaction types in the Fuel Specs: https://docs.fuel.network/docs/nightly/specs/tx-format/transaction/

Changes

  • Adds support for Transaction::Upload, Transaction::Upgrade, and Transaction::Blob.
  • Implements Eq for Transaction
  • Adds missing GTF opcodes. These will be implemented in another PR.
  • Adds additional warnings in inline documentation

Notes

  • Required for mainnet
  • tx_witness_data() returns an Option<T> and thus does not support ownership types. This will be updated to Bytes in the future

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@bitzoic bitzoic added enhancement New feature or request lib: std Standard library labels Sep 5, 2024
@bitzoic bitzoic requested a review from a team September 5, 2024 04:04
@bitzoic bitzoic self-assigned this Sep 5, 2024
@bitzoic bitzoic requested review from a team as code owners September 5, 2024 04:04
@bitzoic bitzoic added the blocked label Sep 5, 2024
@bitzoic
Copy link
Member Author

bitzoic commented Sep 6, 2024

Blocked until FuelLabs/fuel-vm#812 is resovled

@bitzoic bitzoic requested a review from xgreenx September 11, 2024 11:18
@IGI-111 IGI-111 enabled auto-merge (squash) September 11, 2024 14:50
@IGI-111 IGI-111 merged commit d76a146 into master Sep 11, 2024
35 checks passed
@IGI-111 IGI-111 deleted the bitzoic-new-transaction-types branch September 11, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lib: std Standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants