Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional name for RawCSS option #703

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Conversation

reboost
Copy link
Contributor

@reboost reboost commented Jun 28, 2021

Proposed changes

Added an optional name property to RawCSS option to be used (instead of using undefined) when creating the result's file property.

At the moment the result returns undefined for the file property when using the RawCSS option, adding an identifier name would be great to differentiate between the result of multiple RawCSS data.

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Test for this feature is included.

@Ffloriel Ffloriel merged commit 7303077 into FullHuman:master Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants