This repository has been archived by the owner on Jul 13, 2020. It is now read-only.
Fixes 0 health actor being selected #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
suggested changes
Mar 9, 2018
JoshuaKGoldberg
suggested changes
Mar 9, 2018
src/BattleMovr.ts
Outdated
|
|
||
| return i; |
There was a problem hiding this comment.
Interesting. If no actors are alive, what should we do here?
The battle can't start if none are provided, let's throw an error instead.
|
I was getting a linting error about moving the method outside of the class since it doesn't use this anywhere so I did that and added an error message as well. |
JoshuaKGoldberg
approved these changes
Mar 9, 2018
|
@Phansa there are a few stylistic differences in this from the rest of the code, but they're super small and nitpicky so I'll make them myself. 👍 |
JoshuaKGoldberg
approved these changes
Mar 9, 2018
This was referenced Mar 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a scenario where an actor with 0 health can be sent out in battle. It will now check for the first actor who has current health !== 0 and send that out.