-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add liquidity testing to integration testing #549
Conversation
WalkthroughThe changes introduce enhanced cross-chain testing capabilities. A new Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant Tester
participant IntegrationTest
participant Ethereum
participant BSC
Tester->>IntegrationTest: Run TestRun
IntegrationTest->>Ethereum: Setup Token Mapping
IntegrationTest->>BSC: Setup Token Mapping
IntegrationTest->>Ethereum: Initiate Token Transfer
Ethereum-->>IntegrationTest: Transfer Confirmation
IntegrationTest->>BSC: Validate Transfer
BSC-->>IntegrationTest: Transfer Validated
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- tests/crosschain_suite.go (2 hunks)
- tests/crosschain_test.go (1 hunks)
- tests/integration_test.go (1 hunks)
- tests/suite.go (1 hunks)
Files skipped from review due to trivial changes (1)
- tests/suite.go
Additional comments not posted (3)
tests/integration_test.go (1)
68-68
: LGTM! Ensure thatLiquidityTest
is properly implemented and tested.tests/crosschain_test.go (1)
250-293
: The implementation ofLiquidityTest
appears comprehensive, covering various aspects of liquidity testing across chains. Ensure that all external dependencies and APIs used in this function are stable and well-tested.tests/crosschain_suite.go (1)
101-108
: The addition ofQueryPendingPoolSendToExternal
enhances the suite's capabilities to query pending transactions. Ensure that this function is used appropriately in tests that require this functionality.
mg |
Summary by CodeRabbit
New Features
Bug Fixes
Tests