Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override .attributes method on legacy EncryptedModel and adds .unencr… #76

Merged
merged 2 commits into from
May 2, 2019
Merged

Override .attributes method on legacy EncryptedModel and adds .unencr… #76

merged 2 commits into from
May 2, 2019

Conversation

ahmetabdi
Copy link

@ahmetabdi ahmetabdi commented Apr 29, 2019 •
edited
Loading

…ypted_attributes method

Updates .attributes method in Legacy EncryptedModel as it was not returning the values for the vault_attribute

Adds .unencrypted_attributes method, In some instances it is helpful to get all attributes apart from encrypted values e.g. if .attributes is being returned through an API

/cc @FundingCircle/gdpr-engineering

popovm
popovm approved these changes May 2, 2019
View reviewed changes
Copy link
Member

@popovm popovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ahmetabdi ahmetabdi merged commit 56989b2 into master May 2, 2019
@ahmetabdi ahmetabdi deleted the gdpreng-894_override_attributes_legacy branch May 2, 2019 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popovm popovm popovm approved these changes

@b-murphy-fc b-murphy-fc b-murphy-fc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmetabdi @popovm @b-murphy-fc