Fixes bug with memory decryption not handing blank values #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
Vault::Rails.enabledisfalsein-memory decryption/encryption is used.There was an error where when the ciphertext was a blank string in tests https://github.com/FundingCircle/fc-vault-rails/blob/master/lib/vault/rails.rb#L229 would cause the code to raise a error of
ArgumentError: iv must be 16 bytes.This fixes the issue by returning the ciphertext if the ciphertext is blank
/cc @FundingCircle/gdpr-engineering