Add Rails 6 support #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klebervirgilio
force-pushed
the
add-rails6-support
branch
7 times, most recently
from
8f9aa57
to
b671472
Compare
michaellennox
approved these changes
Dec 2, 2019
ahmetabdi
reviewed
Dec 2, 2019
ahmetabdi
approved these changes
Dec 2, 2019
The "wwtd" rubygem along with Travis CI configuration file basically run the suite test against different versions of Ruby and Rails. This causes problems when the ruby/rails combination are ruby versions lower than 2.5 and the rails version is 6 since this version of rails only supports ruby version 2.5.0 or higher.
SQLite3 gem on ActiveRecord 6 needs to be higher than 1.3, this commit makes sure each Gemfile has its proper version
klebervirgilio
force-pushed
the
add-rails6-support
branch
from
b671472
to
c075fea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Rails 6 support to fc-vault-rails. Also, this PR moves the build pipeline completely to CircleCi which among other benefits allow us to perform the tests in parallel.