Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an article about jackdaw.admin #211

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Add an article about jackdaw.admin #211

merged 1 commit into from
Dec 3, 2019

Conversation

AlexVPopov
Copy link
Contributor

@AlexVPopov AlexVPopov commented Nov 1, 2019

This is a first stab at providing a small guide to the jackdaw.admin namespace.

Checklist

  • [] tests
  • [ ] updated CHANGELOG (the "unreleased" section)

@AlexVPopov AlexVPopov requested a review from a team as a code owner November 1, 2019 14:03
cddr
cddr previously approved these changes Nov 2, 2019
Copy link
Contributor

@cddr cddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to add this documentation @AlexVPopov! Spotted one typo and a suggestion to use vector instead of array which seems a bit more clojurey :-)

doc/admin.md Outdated Show resolved Hide resolved
doc/admin.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #211 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #211   +/-   ##
=======================================
  Coverage   79.78%   79.78%           
=======================================
  Files          42       42           
  Lines        2572     2572           
  Branches      150      150           
=======================================
  Hits         2052     2052           
  Misses        370      370           
  Partials      150      150

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc799f6...7c6beb4. Read the comment docs.

cddr
cddr previously approved these changes Dec 3, 2019
@AlexVPopov
Copy link
Contributor Author

@cddr PR updated.

@cddr cddr merged commit d88e97a into master Dec 3, 2019
@cddr cddr deleted the add-admin-docs branch December 3, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants