Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies in CircleCI build #217

Merged
merged 5 commits into from
Dec 3, 2019
Merged

Conversation

sgerrand
Copy link
Contributor

@sgerrand sgerrand commented Dec 3, 2019

💁 Updates the version of

  • Leiningen
  • Confluent Platform components

in the CircleCI build configuration.

@sgerrand sgerrand requested a review from a team as a code owner December 3, 2019 14:05
@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #217 into master will decrease coverage by 0.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
- Coverage   79.78%   79.39%   -0.39%     
==========================================
  Files          42       42              
  Lines        2572     2572              
  Branches      150      150              
==========================================
- Hits         2052     2042      -10     
- Misses        370      380      +10     
  Partials      150      150
Impacted Files Coverage Δ
src/jackdaw/serdes/edn2.clj 45.45% <0%> (-45.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d88e97a...922803d. Read the comment docs.

@sgerrand sgerrand force-pushed the circleci-config-updates branch from 5f65172 to 36c2ade Compare December 3, 2019 14:25
@cddr
Copy link
Contributor

cddr commented Dec 3, 2019

Thanks @sgerrand. Might also be worth putting a link to the kafka upgrade documentation in the Changelog entry for this PR.

https://kafka.apache.org/23/documentation.html#upgrade_230_notable

@sgerrand sgerrand force-pushed the circleci-config-updates branch from 6c9b294 to 03e8468 Compare December 3, 2019 15:00
@sgerrand
Copy link
Contributor Author

sgerrand commented Dec 3, 2019

@cddr Updated! ♻️

sgerrand and others added 4 commits December 3, 2019 15:21
Updates the various components from Confluent's Platform to version 5.3.1, the latest generally available version.
@sgerrand sgerrand force-pushed the circleci-config-updates branch from 03e8468 to 6adc6c4 Compare December 3, 2019 15:22
@sgerrand
Copy link
Contributor Author

sgerrand commented Dec 3, 2019

@cddr and again. ♻️

cddr
cddr previously approved these changes Dec 3, 2019
@sgerrand sgerrand merged commit a08db3a into master Dec 3, 2019
@sgerrand sgerrand deleted the circleci-config-updates branch December 3, 2019 15:29
@cddr cddr mentioned this pull request Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants