Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Kafka 2.4.1 #270

Closed
wants to merge 3 commits into from
Closed

Conversation

csenol
Copy link

@csenol csenol commented Aug 17, 2020

Checklist

  • tests
  • updated CHANGELOG (the "unreleased" section)

@csenol csenol requested a review from a team as a code owner August 17, 2020 08:05
@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #270 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #270   +/-   ##
=======================================
  Coverage   81.16%   81.16%           
=======================================
  Files          41       41           
  Lines        2586     2586           
  Branches      153      153           
=======================================
  Hits         2099     2099           
  Misses        334      334           
  Partials      153      153           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daa8387...d59232f. Read the comment docs.

@csenol
Copy link
Author

csenol commented Aug 17, 2020

Kafka 2.4 is providing new partition assignment strategies such as cooperative-sticky
It would be good if jackdaw can catch-up

@cddr
Copy link
Contributor

cddr commented Aug 18, 2020

Might be worth also updating the images used by CI to the corresponding confluent release.

https://github.com/FundingCircle/jackdaw/blob/master/.circleci/config.yml#L44

Copy link
Contributor

@cddr cddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@csenol
Copy link
Author

csenol commented Aug 18, 2020

Thanks for the review.
When are you planning to have a release?

@cddr
Copy link
Contributor

cddr commented Aug 19, 2020

I'm no longer an administrator so dunno when someone will be able to get a release out. If you have a pressing need though, you may be able to just override the kafka dependencies in your own project.clj.

@mt3593
Copy link

mt3593 commented Aug 24, 2020

Any update on this, any administrators able to get a release out?

@robert-pierce
Copy link

Following ... we could use the new support for Named class. We are producing graph images of our topologies as a method of documentation, and naming the nodes would be extremely helpful.

@dakra
Copy link

dakra commented Dec 30, 2020

fyi, I have merged a few PRs that I needed (including this one) in my fork.
I also published it to clojars.

I don't really want to maintain this fork or make something official
or anything. I just did it because I needed it personally, maybe it
helps you too until @FundingCircle picks development up again.

@gphilipp
Copy link
Contributor

Closing since we upgraded to 2.8.0 via #292

@gphilipp gphilipp closed this Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants