Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs #287

Merged
merged 15 commits into from
May 7, 2021
Merged

Fix docs #287

merged 15 commits into from
May 7, 2021

Conversation

LouiseKlodt
Copy link
Contributor

@LouiseKlodt LouiseKlodt commented Apr 12, 2021

Summary of changes

Fixes the code examples and documentation for test-machine

  • tests
  • updated CHANGELOG (the "unreleased" section)

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #287 (a7edf5d) into master (b4f6710) will increase coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
+ Coverage   80.05%   80.42%   +0.36%     
==========================================
  Files          42       42              
  Lines        2753     2753              
  Branches      157      157              
==========================================
+ Hits         2204     2214      +10     
+ Misses        392      382      -10     
  Partials      157      157              
Impacted Files Coverage Δ
src/jackdaw/serdes/edn2.clj 90.90% <0.00%> (+45.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4f6710...a7edf5d. Read the comment docs.

@cddr
Copy link
Contributor

cddr commented Apr 29, 2021

Thanks for giving the docs some ❤️ Louise. Particularly the note about :partition-count. That's a common stumbling block.

@LouiseKlodt LouiseKlodt marked this pull request as ready for review May 4, 2021 15:31
@LouiseKlodt LouiseKlodt requested a review from a team as a code owner May 4, 2021 15:31
minimal
minimal previously approved these changes May 5, 2021
doc/test-machine.md Outdated Show resolved Hide resolved
doc/test-machine.md Show resolved Hide resolved
@LouiseKlodt LouiseKlodt merged commit d853d4c into master May 7, 2021
@LouiseKlodt LouiseKlodt deleted the fix-docs branch May 7, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants