Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): add -repo to repo cache names to not match with deps cache #288

Merged
merged 2 commits into from
Apr 14, 2021

Conversation

minimal
Copy link
Contributor

@minimal minimal commented Apr 14, 2021

Is failing due to fallback to v1-jackdaw-* and matching with v1-jackdaw-deps

@minimal minimal requested a review from marcoccchan April 14, 2021 10:40
@minimal minimal requested a review from a team as a code owner April 14, 2021 10:40
@minimal minimal marked this pull request as draft April 14, 2021 10:41
marcoccchan
marcoccchan previously approved these changes Apr 14, 2021
Copy link
Contributor

@marcoccchan marcoccchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #288 (6d47fd5) into master (a9662e7) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
- Coverage   80.56%   80.42%   -0.15%     
==========================================
  Files          42       42              
  Lines        2753     2753              
  Branches      157      157              
==========================================
- Hits         2218     2214       -4     
- Misses        380      382       +2     
- Partials      155      157       +2     
Impacted Files Coverage Δ
src/jackdaw/test/transports/rest_proxy.clj 84.68% <0.00%> (-1.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9662e7...6d47fd5. Read the comment docs.

Is failing due to fallback to v1-jackdaw-* and matching with v1-jackdaw-deps
@minimal minimal force-pushed the fix-repo-cache-name branch from ac118e6 to cfc3b51 Compare April 14, 2021 10:55
@minimal minimal marked this pull request as ready for review April 14, 2021 10:58
@minimal minimal force-pushed the fix-repo-cache-name branch from cfc3b51 to 6d47fd5 Compare April 14, 2021 11:00
@minimal minimal merged commit d23a069 into master Apr 14, 2021
@minimal minimal deleted the fix-repo-cache-name branch April 14, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants