Add KStream-KTable inner join #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main changes are: - Move the join method from IKTable to IKStreamBase. Also move the join implementations for KTable-KTable joins and the join function accordingly. - Add join implementations for ConfiguredKStream and CljKStream. - Update the spec for join.
simon-katz
force-pushed
the
stream-table-inner-join
branch
from
f0e9fab to
1a4b7ac
Compare
gphilipp
approved these changes
Jun 30, 2021
There was a problem hiding this comment.
Hey @simon-katz, thank you for this PR, it looks really good ✨.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for KStream-KTable inner joins. See the commit message for details.
Checklist