Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Schema SERDE #300

Merged
merged 7 commits into from
Aug 12, 2021
Merged

Conversation

kidpollo
Copy link
Contributor

@kidpollo kidpollo commented Jul 22, 2021

Checklist

  • tests
  • updated CHANGELOG (the "unreleased" section)

@kidpollo kidpollo requested a review from a team as a code owner July 22, 2021 23:00
@kidpollo kidpollo changed the title wip [WIP] JSON Schema SERDE Jul 22, 2021
@kidpollo
Copy link
Contributor Author

Still working through issues with top level Array types. The deserializer does not like them :(

@kidpollo
Copy link
Contributor Author

@99-not-out @gphilipp Would love your input on this pr so far

👋🏽 btw, how are things going?

@kidpollo kidpollo changed the title [WIP] JSON Schema SERDE JSON Schema SERDE Jul 23, 2021
@kidpollo
Copy link
Contributor Author

Should handle top level arrays now

@gphilipp
Copy link
Contributor

Hi @kidpollo Hope everything is well for you 👋. Would you mind renaming the commits (get rid of wip-)?

@kidpollo kidpollo force-pushed the json-schema-serde branch from 4915602 to 96fe175 Compare July 26, 2021 18:01
@kidpollo
Copy link
Contributor Author

Done @gphilipp

gphilipp
gphilipp previously approved these changes Aug 4, 2021
@kidpollo
Copy link
Contributor Author

Ok now i' sure this works on kstreams topologies :P

Copy link
Contributor

@gphilipp gphilipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Paco

@gphilipp gphilipp merged commit 24c7f5f into FundingCircle:master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants