Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some additions and helpers for Kafka Streams interop #305

Merged
merged 4 commits into from
Nov 18, 2021
Merged

Some additions and helpers for Kafka Streams interop #305

merged 4 commits into from
Nov 18, 2021

Conversation

99-not-out
Copy link
Contributor

@99-not-out 99-not-out commented Oct 22, 2021 •
edited
Loading

  • added simple helpers in lambdas for using transformers more easily in a stream
  • added the flatTransform and flatTransfromValues calls to the core streams interface
  • added a helper function to add KV state stores to a streams builder

@99-not-out 99-not-out added the WIP label Oct 22, 2021
@99-not-out 99-not-out requested a review from a team as a code owner October 22, 2021 10:10
@99-not-out 99-not-out changed the title [WIP] Some helpers for Kafka Streams interop Some helpers for Kafka Streams interop Nov 15, 2021
@99-not-out 99-not-out removed the WIP label Nov 15, 2021
@99-not-out 99-not-out changed the title Some helpers for Kafka Streams interop Some additions and helpers for Kafka Streams interop Nov 15, 2021
@kidpollo kidpollo mentioned this pull request Nov 16, 2021
Closed
@kidpollo
Copy link
Contributor

I might work with this one as this one looks newer :P

@99-not-out
Copy link
Contributor Author

I might work with this one as this one looks newer :P

Yes @kidpollo - this one will be the merged version of these additions (and the other older PR is closed out now)

gphilipp
gphilipp reviewed Nov 17, 2021
View reviewed changes
src/jackdaw/streams/interop.clj Show resolved Hide resolved
src/jackdaw/streams/lambdas.clj Outdated Show resolved Hide resolved
src/jackdaw/streams/lambdas.clj Outdated Show resolved Hide resolved
src/jackdaw/streams/mock.clj Show resolved Hide resolved
src/jackdaw/streams/mock.clj Show resolved Hide resolved
test/jackdaw/streams_test.clj Show resolved Hide resolved
test/jackdaw/streams_test.clj Outdated Show resolved Hide resolved
@kidpollo
Copy link
Contributor

kidpollo commented Nov 17, 2021 via email

gphilipp
gphilipp previously approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@gphilipp gphilipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gphilipp
Copy link
Contributor

Let's add a CHANGELOG entry

@gphilipp gphilipp merged commit 22423d5 into master Nov 18, 2021
@gphilipp gphilipp deleted the ms-extras branch November 18, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattford63 mattford63 mattford63 left review comments

@gphilipp gphilipp gphilipp approved these changes

@minimal minimal minimal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@99-not-out @kidpollo @gphilipp @minimal @mattford63