Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to kafka v3.2.0 and update deps #321

Closed
wants to merge 1 commit into from

Conversation

ghaskins
Copy link
Contributor

Signed-off-by: Greg Haskins greg@manetu.com

Signed-off-by: Greg Haskins <greg@manetu.com>
@ghaskins ghaskins requested a review from a team as a code owner May 29, 2022 17:18
@gphilipp
Copy link
Contributor

gphilipp commented Jun 1, 2022

Hi @ghaskins, thanks for the PR this is very much appreciated. We've discussed this internally and would prefer to see it split into 3 PRs:

  • one that allows to stick with 2.x but removes all calls to deprecated stuff and upgrades libs
  • one that upgrades to 3.2.0
  • last one to upgrade to clojure 1.11.1

I'll cherry pick changes from your branch if you don't mind (and give credit where it's due of course).

@ghaskins
Copy link
Contributor Author

ghaskins commented Jun 1, 2022

@gphilipp the plan makes sense, and of course I don't mind. Ty!

BTW: I actually tried a variation of your proposal (doing the 2.x with updates as a different patch) and it was inexplicably failing UTs. I didn't investigate too deeply, though, since I had just finished getting the 3.2 port to work. I did not try to split clojure out, though.

@mt3593
Copy link

mt3593 commented Oct 10, 2022

Hi all, any update on this? Happy to help out if I can.

@kidpollo
Copy link
Contributor

@marcoccchan @99-not-out this is also important. Specially for ppl with M1 macs. There is even newer kafka libs now. I also don't see a point of splitting this into multiple prs

@minimal minimal mentioned this pull request Mar 31, 2023
2 tasks
@minimal
Copy link
Contributor

minimal commented May 5, 2023

Thanks this was included in #353 and released in https://github.com/FundingCircle/jackdaw/releases/tag/0.9.10

@minimal minimal closed this May 5, 2023
@ghaskins ghaskins deleted the kafka-3.2 branch March 13, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants