Lint all the code #323
Merged
Lint all the code #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gphilipp
force-pushed
the
upgrade-deps
branch
2 times, most recently
from
3cf92c7 to
ea9a365
Compare
gphilipp
force-pushed
the
upgrade-deps
branch
2 times, most recently
from
f0c9de8 to
fb80e61
Compare
added 6 commits
June 1, 2022 21:51
…d manifold.deferred/loop
added 10 commits
June 1, 2022 23:25
jbropho
reviewed
Jun 6, 2022
| @@ -100,6 +100,14 @@ jobs: | |||
| key: v1-jackdaw-repo-{{ .Branch }}-{{ .Revision }} | |||
| paths: | |||
| - . | |||
| lint: | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Jackdaw is still using circleci, not drone.
gphilipp
changed the title
Only left the more tricky ones which will be tackled in a later commit
added 6 commits
June 7, 2022 13:28
The private function jackdaw.test.fixtures/delete-topics isn't used
Ignore thrown-with-msg-and-data which extends the `clojure.test/is` macro
We purposely redefine the fns created by defmacro.
to trigger another build and see if the FC checks are still there
99-not-out
previously approved these changes
Jun 10, 2022
99-not-out
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on cleaning the code up:
Note: review commit per commit
Checklist