Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reflection warnings #358

Merged
merged 2 commits into from
Apr 25, 2023
Merged

fix reflection warnings #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c4e4f4
fix reflection warnings
AndrewKeedle Apr 18, 2023
13a5ad5
CHANGELOG
AndrewKeedle Apr 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,6 @@ pom.xml.asc
.cpcache
.nrepl-port
/examples/*/target
.clj-kondo/
.lsp/
.calva/
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

### Unreleased

- v0.9.10 introduced some reflection warnings. Whilst harmless seeing `.deleteTopics` appear in your logs at app startup is a little unsettling.

### [0.9.10] - [2023-04-03]
- Kafka 3.x series compatibility. Specifically 3.3.2 with this release (including native support for Arm macs) (https://github.com/FundingCircle/jackdaw/pull/353, https://github.com/FundingCircle/jackdaw/pull/355)

Expand Down
10 changes: 5 additions & 5 deletions src/jackdaw/admin.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
(:require
[jackdaw.data :as jd]
[manifold.deferred :as d])
(:import [java.util Properties]
(:import [java.util Collection Properties]
[org.apache.kafka.clients.admin AdminClient
DescribeTopicsOptions DescribeClusterOptions DescribeConfigsOptions]))

Expand All @@ -30,13 +30,13 @@
@(.all (.alterConfigs ^AdminClient this topics))))
:create-topics* (fn [this topics]
(d/future
@(.all (.createTopics ^AdminClient this topics))))
@(.all (.createTopics ^AdminClient this ^Collection topics))))
:delete-topics* (fn [this topics]
(d/future
@(.all (.deleteTopics ^AdminClient this topics))))
@(.all (.deleteTopics ^AdminClient this ^Collection topics))))
:describe-topics* (fn [this topics]
(d/future
@(.all (.describeTopics ^AdminClient this topics (DescribeTopicsOptions.)))))
@(.all (.describeTopics ^AdminClient this ^Collection topics (DescribeTopicsOptions.)))))
:describe-configs* (fn [this configs]
(d/future
@(.all (.describeConfigs ^AdminClient this configs (DescribeConfigsOptions.)))))
Expand Down Expand Up @@ -95,7 +95,7 @@
false

:else
(do (Thread/sleep wait-ms)
(do (Thread/sleep ^long wait-ms)
(recur client topic (dec num-retries) wait-ms))))

(defn create-topics!
Expand Down
2 changes: 1 addition & 1 deletion src/jackdaw/test/commands/base.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
{:stop (constantly true)

:sleep (fn [_machine [sleep-ms]]
(Thread/sleep sleep-ms))
(Thread/sleep ^long sleep-ms))

:println (fn [_machine params]
(println (apply str params)))
Expand Down