Merge pull request #80 from FundingCircle/disable_action_dispatch_deb…

…ug_exceptions

Disable ActionDispatch::DebugExceptions

lib/loga/ext/rails/rack/debug_exceptions.rb

@@ -0,0 +1,8 @@
+module ActionDispatch
+  class DebugExceptions
+    private
+
+    def logger(_request)
+    end
+  end
+end

lib/loga/railtie.rb

@@ -63,6 +63,7 @@ def call
         insert_loga_rack_logger
         disable_rails_rack_logger
         insert_exceptions_catcher
+        disable_action_dispatch_debug_exceptions
       end
 
       private
@@ -88,6 +89,10 @@ def disable_rails_rack_logger
         end
       end
 
+      def disable_action_dispatch_debug_exceptions
+        require 'loga/ext/rails/rack/debug_exceptions.rb'
+      end
+
       def insert_loga_rack_logger
         app.middleware.insert_after Rails::Rack::Logger,
                                     Loga::Rack::Logger,

lib/loga/version.rb

@@ -1,3 +1,3 @@
 module Loga
-  VERSION = '1.2.1'.freeze
+  VERSION = '1.3.0'.freeze
 end

spec/integration/rails/request_spec.rb

@@ -39,4 +39,12 @@
       expect(action_view_notifications).to be_empty
     end
   end
+
+  describe 'when request causes ActionDispatch 404' do
+    it 'does not log ActionDispatch::DebugExceptions' do
+      get '/not_found', {}, 'HTTP_X_REQUEST_ID' => '471a34dc'
+      expect(json_entries.count).to eq(1)
+      expect(json['short_message']).to eq('GET /not_found 404 in 0ms')
+    end
+  end
 end