-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attach context #112
base: master
Are you sure you want to change the base?
Attach context #112
Conversation
2588d30
to
33e3019
Compare
👀 |
* Sidekiq * Sinatra * ActionMailer * Rails
🤔 Unfortunately the current implementation won't do / needs expanding. The main problem is that when we trace something e.g. sidekiq job or a rack request we want to pass some metadata to that trace e.g. Overall we can refactor a bit more and extract the tracing so from e.g.
I'll continue the PR ☝️ direction. The dsl is still questionable ;) |
Closing, stale and probably no longer needed. |
Needed but not trivial to implements so.. we haven't spend the time :) -> Opening again |
Would the code here be reused or would the author probably start from scratch? |
No idea. If/when I try I'll use the current PR. Assume this PR as an Issue with some code :) |
Loga::Configuration
.Fixes #77