Fix rails 7.1 support and migrate to github actions #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ SAST ReportNo issues found. Good job! 💪 |
bliof-fc
force-pushed
the
migrate-to-gh-actions
branch
6 times, most recently
from
fc18ba3
to
12523eb
Compare
bliof-fc
force-pushed
the
migrate-to-gh-actions
branch
from
12523eb
to
cc86538
Compare
Add sinatra2, sinatra3, sinatra4 Remove rails42, rails50
bliof-fc
force-pushed
the
migrate-to-gh-actions
branch
from
cc86538
to
d57eed8
Compare
The main part of the project will be fixed in a separate PR.
bliof-fc
force-pushed
the
migrate-to-gh-actions
branch
from
d57eed8
to
127420d
Compare
In ruby 3.3 it is just `undefined method 'name' for nil` In the others, it is nil:NilClass
bliof-fc
force-pushed
the
migrate-to-gh-actions
branch
from
ee49dd0
to
b284a41
Compare
bliof-fc
force-pushed
the
migrate-to-gh-actions
branch
4 times, most recently
from
b98a5ee
to
d60061a
Compare
bliof-fc
changed the title
Add rails 7.1 Remove fixutures for 4.2 and 5.0 Add mutex_m for ruby 3.3.0 Add base64 gem to rails 7.0 and 7.1 to fix: ``` > BUNDLE_GEMFILE=/home/runner/work/loga/loga/gemfiles/rails70.gemfile bundle exec rspec /home/runner/.rubies/ruby-head/lib/ruby/gems/3.4.0+0/gems/activesupport-7.0.8/lib/active_support/message_verifier.rb:4: warning: base64 was loaded from the standard library, but is not part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec. Failure/Error: require 'rails' LoadError: cannot load such file -- base64 ``` https://stdgems.org/base64/ The root issue is that in old ruby version base64 0.1.1 should be used and base64 0.2.0 is just for ruby 3.3.0 There is some new ActiveSupport::BroadcastLogger in development in rails 7.1 that is not getting assigned to the Loga.logger. This will be checked in a followup change
bliof-fc
force-pushed
the
migrate-to-gh-actions
branch
from
7a25d03
to
8f386a0
Compare
popovm
approved these changes
Feb 12, 2024
sgerrand
reviewed
Feb 12, 2024
bliof-fc
force-pushed
the
migrate-to-gh-actions
branch
from
b2d7954
to
af1a5f5
Compare
Add ruby 3.3 to the matrix. `head` is 3.3 but will change in the future. Co-authored-by: Sasha Gerrand <sgerrand@users.noreply.github.com>
Fix logging of exceptions in rails 7.1 Update the CI pipeline
bliof-fc
force-pushed
the
migrate-to-gh-actions
branch
from
af1a5f5
to
a3b204f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to github actions
Run tests against:
Test with rails - 5.2, 6.0, 6.1, 7.0, 7.1
Test with sinatra - 1.4, 2.2, 3.2, 4.0
Test with sidekiq - 5.1, 6.0, 6.1, 6.2, 6.3, 6.4, 6.5, 7.0, 7.1, 7.x
Fix for rails 7.1
In rails 7.1 https://github.com/rails/rails/blob/v7.1.3/actionpack/lib/action_dispatch/middleware/debug_exceptions.rb#L56
vs rails 7.0 https://github.com/rails/rails/blob/v7.0.8/actionpack/lib/action_dispatch/middleware/debug_exceptions.rb#L54
With rails 7.1 there is also a new
ActiveSupport::BroadcastLogger, that is currently not in use bylogahttps://github.com/rails/rails/blob/v7.1.3/activesupport/lib/active_support/broadcast_logger.rb