Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: desktop audio quality issue #2980

Closed
cyn0x8 opened this issue Jul 7, 2024 · 15 comments
Closed

Bug Report: desktop audio quality issue #2980

cyn0x8 opened this issue Jul 7, 2024 · 15 comments
Labels
status: resolved The issue has been fixed or the suggestion has been implemented. type: minor bug Involves a minor bug or issue.

Comments

@cyn0x8
Copy link
Contributor

cyn0x8 commented Jul 7, 2024

Describe the bug

the audio quality/clarity on desktop builds is noticeably worse than that of html5/web builds (at least on windows, im unable to test on mac/linux)

To Reproduce

simply play the game on desktop and web and compare the audio quality to each other

Expected behavior

game audio should sound the same as in html5 builds or a media player

Screenshots/Video

desktop:

2024-07-07.16-07-18.mp4

web:

2024-07-07.16-08-02.mp4

Desktop

  • OS: Windows 10, Windows 11
  • Version: 0.4.1 (as well as earlier versions, and even other engines)
@cyn0x8 cyn0x8 changed the title Bug Report: audio quality issue Bug Report: desktop audio quality issue Jul 7, 2024
@Hundrec
Copy link
Collaborator

Hundrec commented Jul 7, 2024

The difference in audio quality is due to the use of .ogg files rather than html's .mp3 files.

This might be a limitation with HaxeFlixel, so the audio quality may always be different between desktop and web.

@cyn0x8
Copy link
Contributor Author

cyn0x8 commented Jul 8, 2024

The difference in audio quality is due to the use of .ogg files rather than html's .mp3 files.

This might be a limitation with HaxeFlixel, so the audio quality may always be different between desktop and web.

the audio quality in the files themselves are pretty much the same, the change only appears ingame
unless you mean like how theyre decoded

also i asked around and was told this is likely lime/openfl related so maybe it can be fixed in a fork??

@Hundrec
Copy link
Collaborator

Hundrec commented Jul 8, 2024

Whoops, I mistakenly equated file size with audio quality!

Anyway, I do hope the audio quality can be improved with some code tweaks or even an overhauled audio system.

@cyn0x8
Copy link
Contributor Author

cyn0x8 commented Jul 8, 2024

Whoops, I mistakenly equated file size with audio quality!

Anyway, I do hope the audio quality can be improved with some code tweaks or even an overhauled audio system.

tbh an audio system like fmod would be pretty cool to have in fnf but i dont know if its possible

im guessing itd also fix this weird audio delay that sometimes happens (#57 #2222 #2888) or maybe even eliminate the need to resync audio in the first place

2024-06-29_22-10-59.mp4

@Hundrec
Copy link
Collaborator

Hundrec commented Jul 8, 2024

I love that bug, it's hilarious

The video in #2888 is even funnier

@tposejank
Copy link
Contributor

id probably say js target's audio quality is notably worse when reproducing the audio even if it sounds normal when extracted

@EliteMasterEric
Copy link
Member

I reviewed the videos and I do not hear the issue at all.

Also note that the audio files used for the game itself are fairly low quality on both desktop and web in order to improve bandwidth and download size.

@EliteMasterEric EliteMasterEric added type: minor bug Involves a minor bug or issue. status: needs clarification Requires more info from the author. labels Jul 9, 2024
@Hundrec
Copy link
Collaborator

Hundrec commented Jul 9, 2024

I think the difference in quality is so subtle that most listeners can't even tell the difference through most output devices

@EliteMasterEric EliteMasterEric added status: needs clarification Requires more info from the author. and removed status: needs clarification Requires more info from the author. labels Jul 9, 2024
@cyn0x8
Copy link
Contributor Author

cyn0x8 commented Jul 11, 2024

I reviewed the videos and I do not hear the issue at all.

Also note that the audio files used for the game itself are fairly low quality on both desktop and web in order to improve bandwidth and download size.

both the original mp3 and ogg audio files themselves sound fine (as in played with a media player or something) and also sound nearly the same ingame on the web build

though on desktop something weird seems to be happening ingame where all audio (mostly high treble) feels slightly muted/less crisp and the stereo not as full

it depends on which headphones/speakers/whatever you use, but on decent drivers the difference is noticeable

comparison.mp4

another big indicator of something going on is these artifacts appearing when viewed through a spectrogram (not a bug with the spectrogram, both recordings are pcm wav)

image


I think the difference in quality is so subtle that most listeners can't even tell the difference through most output devices

thats true, but for a music game i think its pretty important to have crisp audio!! im currently working on a mod and want players to hear the music as it was meant to be listened to

@Hundrec
Copy link
Collaborator

Hundrec commented Jul 11, 2024

Whoops, I mistakenly equated file size with audio quality!

Anyway, I do hope the audio quality can be improved with some code tweaks or even an overhauled audio system.

Of course this issue should be corrected! I'm a fan of high audio quality myself :)

@AbnormalPoof
Copy link
Collaborator

both the original mp3 and ogg audio files themselves sound fine (as in played with a media player or something) and also sound nearly the same ingame on the web build

though on desktop something weird seems to be happening ingame where all audio (mostly high treble) feels slightly muted/less crisp and the stereo not as full

it depends on which headphones/speakers/whatever you use, but on decent drivers the difference is noticeable

I do hear it, desktop sounds ever so slightly more muffled

@tposejank
Copy link
Contributor

Personally I don't see it, I respect audiophiles though. My headphones are very cheap

@doggogit
Copy link
Contributor

doggogit commented Aug 4, 2024

I reviewed the videos and I do not hear the issue at all.
Also note that the audio files used for the game itself are fairly low quality on both desktop and web in order to improve bandwidth and download size.

both the original mp3 and ogg audio files themselves sound fine (as in played with a media player or something) and also sound nearly the same ingame on the web build

though on desktop something weird seems to be happening ingame where all audio (mostly high treble) feels slightly muted/less crisp and the stereo not as full

it depends on which headphones/speakers/whatever you use, but on decent drivers the difference is noticeable

comparison.mp4
another big indicator of something going on is these artifacts appearing when viewed through a spectrogram (not a bug with the spectrogram, both recordings are pcm wav)

image

I think the difference in quality is so subtle that most listeners can't even tell the difference through most output devices

thats true, but for a music game i think its pretty important to have crisp audio!! im currently working on a mod and want players to hear the music as it was meant to be listened to

I definitely feel/hear the difference here.

It feels like the web and original version in the recording are on par, with desktop being lower in volume and slightly muffled.

It was subtle in previous recordings, but, it was still noticable.

@cyn0x8
Copy link
Contributor Author

cyn0x8 commented Aug 25, 2024

ive been told this is likely OpenAL virtualizing the audio by default with headphones?? which would make sense that itd sound this way... a game like this doesnt need 3d audio
im not too good with low level stuff but ill still investigate it soon and try to come up with any possible fixes !!

@cyn0x8
Copy link
Contributor Author

cyn0x8 commented Sep 16, 2024

solved by #3318

@cyn0x8 cyn0x8 closed this as completed Sep 16, 2024
@Hundrec Hundrec added status: resolved The issue has been fixed or the suggestion has been implemented. and removed status: needs clarification Requires more info from the author. labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: resolved The issue has been fixed or the suggestion has been implemented. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

No branches or pull requests

6 participants