[ENHANCEMENT] Fix audio muffling/low audio quality by changing OpenAL's default settings

[Smokey555]

Does this PR close any issues? If so, link them below.

#2980

Briefly describe the issue(s) fixed.

Lime's OpenALSoft has a gain limiter on by default which causes audio muffling/lower audio quality. There are also more settings that could cause spatialization etc. to occur resulting in the audio not sounding like it's supposed to compared to outside media players. Adding a default alsoft.ini file fixes this, as it gets automatically detected when it's in the same directory as the executable and applied. This could work for multiple platforms but testing has only been done on Windows

Include any relevant screenshots or videos.

--

[NotHyper-474]

There's definitely a noticeable difference, approved.

(First audio uses the .ini file, second audio does not)

2024-09-16.15-33-49.mp4

[moxie-coder]

This could work for multiple platforms but testing has only been done on Windows

this should work on Linux & Mac since you can specify which audio driver to use & it does have options for Mac & Linux
And these are quoted from the maintainer of AL soft

The default value is blank, which means the current order of the available backends. For the prebuilt binaries (32-bit and 64-bit), the list is, in order:
wasapi, dsound, winmm, null, wave

The current full list, in order, is:
pipewire, pulse (PulseAudio), wasapi, core (CoreAudio for macOS), oboe, opensl, alsa, solaris, sndio, oss (Open Sound System), jack, dsound, winmm (Windows MultiMedia), port (PortAudio), sdl2, null (dummy output), wave (Wave file writer)

Obviously a Windows build won't have all of these... some aren't possible to use on Windows, while others are technically possible but unlikely to be available on Windows.

[Raltyro]

AND IT WAS THIS SIMPLE?!?

[Raltyro]

Something about just putting the file in the game directory frustrates me because it just works like this like something you can configure

(Top is with alsoft.ini, bottom is without)

2024-09-17.21-32-48.mp4

[Raltyro]

Looking this further, you know how this is the default and it's the attended way
Not only was FNF was affected but also every other programs that uses it

[Raltyro]

This could work for multiple platforms but testing has only been done on Windows

this should work on Linux & Mac since you can specify which audio driver to use & it does have options for Mac & Linux And these are quoted from the maintainer of AL soft

https://github.com/kcat/openal-soft/blob/7c1aca7a3134be6fef71b39ee0d426e158dc5446/alsoftrc.sample#L24

[moxie-coder]

Looking this further, you know how this is the default and it's the attended way Not only was FNF was affected but also every other programs that uses it

OpenFL uses OpenAL, and of course AL soft, so anything that uses that you can use that config for

[Raltyro]

All i can say is its fucked that knowing it has a fucked up default config

[EliteMasterEric]

Is there a way to make this work without an extra file in the output folder? Maybe passing some config to OpenAL via code?

[Smokey555]

Is there a way to make this work without an extra file in the output folder? Maybe passing some config to OpenAL via code?

It should be possible using ALC's attribute list, ill look into it

[CCobaltDev]

This could work for multiple platforms but testing has only been done on Windows

this should work on Linux & Mac since you can specify which audio driver to use & it does have options for Mac & Linux And these are quoted from the maintainer of AL soft

https://github.com/kcat/openal-soft/blob/7c1aca7a3134be6fef71b39ee0d426e158dc5446/alsoftrc.sample#L24

so theoretically

<assets path="alsoft.ini" if="windows" />
<assets path="alsoft.ini" rename="alsoft.conf" unless="windows" />

[Raltyro]

yeah basically

[CCobaltDev]

thank you i will be stealing that

[ninjamuffin99]

thank u goat, i'll poke thru this

[cyn0x8]

force-pushed

this pr is so messy

[AbnormalPoof]

Pretty sure you can just update the branch and all the extra commits will be gone

[cyn0x8]

1 nice singular commit now :steamhappy:

[AbnormalPoof]

Dead code elimination is disabled in Funkin'

Funkin/project.hxp

Lines 560 to 562 in c0b15ec

	// Disable dead code elimination.
	// This prevents functions that are unused by the base game from being unavailable to HScript.
	addHaxeFlag("-dce no");

[cyn0x8]

ik for a fact this works on windows but im gonna try testing this on linux and hl rn
is anyone able to test with mac?? i cant emulate cuz its proprietary

[cyn0x8]

just tested
the audio fix works on linux!!