Chart editor audio playback while dragging playheads fix #4140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two down, one to go
github-actions
bot
added
status: pending triage
AbnormalPoof
added
type: minor bug
|
you mean the minimap? it also does that (if the song is playing and you move it the song keeps replaying) i like it because it's funny but it's definely not intended |
…r-audio-playback-while-dragging-playheads-fix
Hmm, that doesn't appear to be the name of the uh, thing. Wait, it's called the note preview playhead. Fixed it! Yay! Wow, it's just feels so clean now too! |
This commit specifically fixes the note preview playhead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
#3791
Briefly describe the issue(s) fixed.
Audio playback in the chart editor isn't automatically stopped while a playhead is dragged around - that, and you can start playback while dragging any of them around too.
This PR fixes this for all 3 playheads - the playbar, grid, and note preview.
Include any relevant screenshots or videos.
2025-02-15.12-06-15.mp4