Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vulnerability): Prototype Pollution Vulnerability #105

Merged
merged 3 commits into from
Aug 29, 2021

Conversation

zero734kr
Copy link
Contributor

@zero734kr zero734kr commented Dec 23, 2020

Screenshot proving that injection has occurred:
image
Note that port 43 in error and port in prototype are same

This pull request is to prevent tentatives of prototype pollution

How to reproduce:

whois.lookup("__proto__", (err, data) => console.log(data))
const obj = {}
console.log(obj.__proto__)
// [Object: null prototype] { port: 43, query: '$addr\r\n' }

@zero734kr zero734kr changed the title fix: prevent prototype injection/derivatives bugs fix(vulnerability): Prototype Injection Vulnerability Dec 23, 2020
@zero734kr zero734kr changed the title fix(vulnerability): Prototype Injection Vulnerability fix(vulnerability): Prototype Pollution Vulnerability Dec 23, 2020
@zero734kr
Copy link
Contributor Author

zero734kr commented Dec 23, 2020

I'm trying to fix indent error thrown by coffeescript, but I never experienced CoffeeScript and don't know what to do to solve. Can you solve this, please?

@hjr265 hjr265 merged commit 46ccc2a into FurqanSoftware:master Aug 29, 2021
@hjr265
Copy link
Member

hjr265 commented Aug 29, 2021

@zero734kr Thanks for the PR. Sorry to take so long to get to this. I have fixed the spacing issue in b98c076.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants