Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minyangu docker-compose.yml #3

Closed
wants to merge 2 commits into from

Conversation

minyangu
Copy link

  • Replaced links with networks. Links is a legacy feature that should avoid using. Added networks for db and search.
  • Updated default restart policy to unless-stopped.
  • Added a sample .env hidden file which contains default environment variables.
  • Added pgadmin for a postgres GUI. Added persistence volume for pgadmin since it needs to store its own credentials and servers.

@robotdan
Copy link
Member

Thanks @minyangu I appreciate the PR.

It looks really good, I'll do a bit of testing on my end and then I should be able to merge in your PR. Thanks for taking the time to contribute!

@robotdan robotdan self-assigned this Nov 27, 2018
@robotdan
Copy link
Member

@minyangu I think for our default compose configuration, I'll leave out the pgadmin image. I can merge your changes in manually, or if you want to update your PR with a separate part docker-compose-pgadmin.yml that includes pgadmin and remove it from the primary docker-compose.yml I could accept it that way.

Do you have a preference?

@robotdan robotdan mentioned this pull request Jan 20, 2019
robotdan pushed a commit that referenced this pull request Jan 26, 2019
@robotdan
Copy link
Member

Manually merged in some of these changes to master. Thanks!

@robotdan robotdan closed this Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants