Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Unified action #19

Merged
merged 7 commits into from
Dec 20, 2021
Merged

feat: Unified action #19

merged 7 commits into from
Dec 20, 2021

Conversation

sumeshir26
Copy link
Member

@im-coder-lg Can you look over the new action which I made which builds for all platforms in one action?
Also, where do you even see draft releases?

@sumeshir26 sumeshir26 merged commit 973693c into master Dec 20, 2021
@sumeshir26 sumeshir26 deleted the unified-action branch December 20, 2021 05:13
@im-coder-lg
Copy link
Member

In the releases page. If you want, modify the url to https://github.com/sumeshir26/TimerX/releases

@sumeshir26
Copy link
Member Author

But, does the msi work now?

@im-coder-lg
Copy link
Member

Idk haven't checked yet but will soon.

@im-coder-lg
Copy link
Member

@sumeshir26 after a long day, I can say it works. I also broke TimerX by spam-clicking the Play button. The resultant output you'd get is this:
If you started spamming immediately, 4 and 3 will be flickering, same everywhere.
I have officially done my first break an app. This is a serious glitch. Imagine a 9-year old kid spamming the Play button and eventually breaking the entire app? Kinda feels like that now.
Also, I have told you about this many times(am I sounding annoyed? If I am, I am not) but you need to check the Play button since by double-clicking it seems to activate the timer, not single-clicking it.
Can you configure the clicking part soon? Also can you find a breakthrough that makes TimerX glitch-resistant to flickering seconds that make your timer endless?

@sumeshir26
Copy link
Member Author

@im-coder-lg The double clickimg is fixed on nef's fork, accidentaly pushed it to thewrongfork. It was canuse by the timer_paused var to be incorrectly set to true on startup.

@sumeshir26
Copy link
Member Author

Also, about the flickering, it seems to be a Tcl/Tk bug, but i'll look into it anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants