-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Dark mode #2
Conversation
I haven't switched yet. Yeah I need permission to switch and it's best done on a Sunday, but I could try Raspbian. |
@im-coder-lg could you try on your pi? |
Well I'll do it soon, maybe by tonight since I got some work to do. |
Have you added a toggle for dark mode here? |
It fails at the icon script... Maybe instead of |
It's the JPEG that disturbs btw |
You don't need to remove the already-existing builds. I saw that Ubuntu succeded, but WIndows, it doesn't know what |
No, it should detect the system theme via darkdetect |
Couldn't experiment checks but I am going to switch to Zorin soon so you have a Linux+Windows(Windows App Support) tester here, but the checks issue, maybe I will edit and send a PR to |
@im-coder-lg I asked you to test on zor in because I know tha zorin had a dark mode and I wanted to test dark mode detection on zorin |
Did it work on Windows? As of now, I think it will fail(Linux btw) due to the
icon(JPEG didn't seem to work on Raspbian) but let's see, it would take a
lot of time to switch to Zorin.
|
It does work on Windows 11 but dark mode on Linux is kind weird because of the many distros |
@im-coder-lg Try now |
Dude I don't have Zorin installed yet! It might work so just comment out the Linux platform code, it seems to disturb the run. |
I think I could do the test tomorrow/Sunday. Flashing time, going into the boot meny, and till it's successfully installed, it will take a lot of time. But what about Gitpod+Xrdp+Xfce desktop? Till I get Zorin? |
@im-coder-lg I’ll try… I will try on replit first |
Wow. I'll be gone for long, I think I'll be finally getting Zorin. Before the installation(which is due evening), however, I'll check on my Win7 PC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/sumeshir26/TimerX/blob/224d91c416e24e83d5b86d1ccf3d9cb48b3b442a/main.py#L24
I think you have to change Windows
to win32
since it fails if it's Windows for me. Does it fail the same for you?
@im-coder-lg Nope? |
Woah, massive bug? Windows 10 also has 32-bit apps, so why not make the change? I have used Windows 10 for a few years, and I got this new PC(well not new, kinda 10 years old) but the dark mode does work. Although it moves the layout a bit, it works fine. |
@im-coder-lg Windows 11 does support 32 bit apps but does not support 32 bit PCs |
@im-coder-lg Try now |
Well, voila. We can use win32 as the code. Windows 11 uses win32 apps but not win32 systems... We can use win32. |
And don't use caps for the system code. |
2 minutes please. |
Windows failed. Console logs: $ python main.py
File "main.py", line 19
elif platform.system() == "darwin":
^
SyntaxError: invalid syntax PS: Using Git Bash since I am a Bash enthusiast. |
@im-coder-lg Alreaday fixed. Try again |
Seems to work and use the JPEG at the same time... Anyway, I'm switching soon, so this ain't much of a problem. |
Great! |
@im-coder-lg Can you test on Zorin OS