feat: Blur Window #46

not-nef · 2022-01-12T15:37:12Z

Im Back.

netlify · 2022-01-12T15:37:18Z

✔️ Deploy Preview for timerx-app canceled.

🔨 Explore the source changes: 35aa821

🔍 Inspect the deploy log: https://app.netlify.com/sites/timerx-app/deploys/61e192890f6250000848ab6e

im-coder-lg · 2022-01-13T03:48:31Z

Any toggle for that though?

im-coder-lg · 2022-01-13T03:49:24Z

Wait I'll try activating checks for macOS and Linux.

im-coder-lg · 2022-01-13T04:04:44Z

Can you try opening a Gitpod env and test it? Also try testing the same on your Mac Mini. But don't use your dad's Mac Mini.
I expect you have Git and Python 3.8+ on your Mac mini, so try these steps:

git clone https://github.com/sumeshir26/TimerX.git
cd TimerX
git checkout Blur
git fetch && git pull
pip install -r requirements.txt
python main.py

Check the TimerX console on Gitpod for the error. I will test on my RasPi soon, kinda busy.

sumeshir26 · 2022-01-13T04:10:53Z

@not-nef This is definitely not intended LOL 😂:-

FYI, OS in Dark Mode, TimerX in Light

im-coder-lg · 2022-01-13T04:17:55Z

lol that's abnormal

not-nef · 2022-01-13T05:31:27Z

@not-nef This is definitely not intended LOL 😂:-

FYI, OS in Dark Mode, TimerX in Light

Well no it isnt lmao

not-nef · 2022-01-13T05:33:28Z

Wait I'll try activating checks for macOS and Linux.

It literally did checks for macos

not-nef · 2022-01-13T05:34:58Z

Can you try opening a Gitpod env and test it? Also try testing the same on your Mac Mini. But don't use your dad's Mac Mini.
I expect you have Git and Python 3.8+ on your Mac mini, so try these steps:
git clone https://github.com/sumeshir26/TimerX.git
cd TimerX
git checkout Blur
git fetch && git pull
pip install -r requirements.txt
python main.py
Check the TimerX console on Gitpod for the error. I will test on my RasPi soon, kinda busy.

Uhm, why?

sumeshir26 · 2022-01-13T05:37:09Z

Uhm, why?

To make sure that blur isnt broken on Mac

not-nef · 2022-01-13T05:46:53Z

I was planning to disable it for mac, but ok

not-nef · 2022-01-13T05:47:37Z

And the dmg still doesn't work i thought you guys dropped macos support

im-coder-lg · 2022-01-13T06:18:27Z

It literally did checks for macos

That was just the DMG build. The real test has to be done on a real/imaginary(VM) computer.

not-nef · 2022-01-13T07:25:55Z

But it doesn't run the dmg so i thought you dropped macos support @im-coder-lg

not-nef · 2022-01-14T06:13:32Z

@sumeshir26 can you give me instructions on what to do next in this pr?

sumeshir26 · 2022-01-14T06:40:49Z

@not-nef First, I'll create a PR in the Sun Valley TTk Theme Repo to make the Button and AccentButton background transparent.
Meanwhile, you can figure out how to make acrylic work properly on both light and dark theme.

not-nef · 2022-01-17T05:37:19Z

@sumeshir26 Is there a way to make the corners of the buttons transparent? I think it has to do something with the custom theme because the ttk.Button has no bg parameter

not-nef · 2022-01-17T05:37:55Z

And btw the labels are fixed i just took the old screenshot

not-nef · 2022-01-17T12:38:38Z

@im-coder-lg Can you manually run the checks on this one pls? It still annoys me

im-coder-lg · 2022-01-17T14:57:21Z

Just update your branch and make another change, the checks autoupdate.

not-nef · 2022-01-19T15:46:44Z

Can you check if the file has exactly 702 lines?

not-nef · 2022-01-19T16:00:43Z

Almost the same for me lol.

Did the theme atleast load?

im-coder-lg · 2022-01-20T02:55:15Z

Did the theme atleast load?

Nope.

im-coder-lg · 2022-01-20T02:58:59Z

Can you check if the file has exactly 702 lines?

Yeah it does.

sumeshir26 · 2022-01-20T02:59:46Z

@im-coder-lg Run gh pr checkout 46

im-coder-lg · 2022-01-20T03:01:13Z

That is what I ran, git pulled with --force and ran the main python file. Wait, it could be missing modules, right?

sumeshir26 · 2022-01-20T03:07:59Z

No, run it again. GH CLI creates a local branch if the PR is from another fork, so git pull wont do anything. Also, try to install the requirements again.

im-coder-lg · 2022-01-20T03:19:47Z

Nothing changed. Is there a module error?

im-coder-lg · 2022-01-20T03:21:29Z

Before you ask, the branch is fully updated and I haven't added any new changes.

im-coder-lg · 2022-01-20T03:22:59Z

It's all with the theming! I changed the theme and the old UI is back! So, you might've done something(accidentally) to theming!

sumeshir26 · 2022-01-20T03:30:14Z

For me, it works absolutely beautifully. It is nice and acrilic. can you try to replace all instances of GlobalBlur with Win7Blur?

im-coder-lg · 2022-01-20T03:32:23Z

Also, look here:
https://github.com/TimerX-App/TimerX/blob/6fb4d1dfb613cc3990e65882de4abf15c908d01e/main.py#L133-L144
The title's being used twice, so it's failing. Can we fix this in this PR?

sumeshir26 · 2022-01-20T03:33:47Z

Ok

sumeshir26 · 2022-01-20T03:35:07Z

Fixed

im-coder-lg · 2022-01-20T03:38:13Z

Umm... Is that normal?

im-coder-lg · 2022-01-20T03:47:04Z

GlobalBlur seems to work. However, Win7Blur seems a bad way(check the error above). The Toast Notifier was causing the error, the theming works now. But the toast fails.

im-coder-lg · 2022-01-20T03:47:37Z

Or it was just CMD.

im-coder-lg · 2022-01-20T03:50:21Z

Nothing seems to work yet again.

im-coder-lg · 2022-01-20T03:56:48Z

It seems to have fixed itself. It's puzzling to myself.

sumeshir26 · 2022-01-20T03:58:07Z

Ok, So approve this PR

im-coder-lg · 2022-01-20T03:59:20Z

One minute, apologies. I want to test this again, final test run.

im-coder-lg

Yup, everything's good. The toast notif fails but we'll fix that later.

not-nef · 2022-01-20T05:28:37Z

Lets go

im-coder-lg · 2022-01-25T05:10:38Z

@not-nef can you restore this branch?

im-coder-lg · 2022-01-25T05:11:02Z

I'm thinking of reverting this merge, making another PR from this branch and fixing this,

not-nef · 2022-01-25T05:32:01Z

No, he fixed it in #65

not-nef added 2 commits January 12, 2022 16:35

Update requirements.txt

50fe98a

Blur Window Background

b5691de

not-nef requested review from sumeshir26 and im-coder-lg January 12, 2022 15:38

not-nef added the ready Ready for merge. label Jan 12, 2022

not-nef removed the ready Ready for merge. label Jan 13, 2022

not-nef added 2 commits January 14, 2022 16:10

Merge branch 'sumeshir26:master' into Blur

7d2b2a5

Fix Labels

35aa821

Merge branch 'TimerX-App:master' into Blur

8b22489

This comment has been minimized.

Sign in to view

fix: Fix Notif

90ba20c

im-coder-lg approved these changes Jan 20, 2022

View reviewed changes

sumeshir26 merged commit 0138c58 into Futura-Py:master Jan 20, 2022

not-nef deleted the Blur branch January 20, 2022 05:25

sumeshir26 mentioned this pull request Jan 25, 2022

Theme doesn't load #64

Closed

feat: Blur Window #46

feat: Blur Window #46

Conversation

not-nef commented Jan 12, 2022 • edited Loading

netlify bot commented Jan 12, 2022 • edited Loading

im-coder-lg commented Jan 13, 2022

im-coder-lg commented Jan 13, 2022

im-coder-lg commented Jan 13, 2022

sumeshir26 commented Jan 13, 2022 • edited Loading

im-coder-lg commented Jan 13, 2022

not-nef commented Jan 13, 2022

not-nef commented Jan 13, 2022

not-nef commented Jan 13, 2022

sumeshir26 commented Jan 13, 2022

not-nef commented Jan 13, 2022

not-nef commented Jan 13, 2022

im-coder-lg commented Jan 13, 2022

not-nef commented Jan 13, 2022

not-nef commented Jan 14, 2022

sumeshir26 commented Jan 14, 2022

not-nef commented Jan 17, 2022

not-nef commented Jan 17, 2022

not-nef commented Jan 17, 2022

im-coder-lg commented Jan 17, 2022

This comment has been minimized.

not-nef commented Jan 19, 2022

not-nef commented Jan 19, 2022

im-coder-lg commented Jan 20, 2022

im-coder-lg commented Jan 20, 2022

sumeshir26 commented Jan 20, 2022

im-coder-lg commented Jan 20, 2022

sumeshir26 commented Jan 20, 2022

im-coder-lg commented Jan 20, 2022

im-coder-lg commented Jan 20, 2022

im-coder-lg commented Jan 20, 2022

sumeshir26 commented Jan 20, 2022

im-coder-lg commented Jan 20, 2022

sumeshir26 commented Jan 20, 2022

sumeshir26 commented Jan 20, 2022

im-coder-lg commented Jan 20, 2022

im-coder-lg commented Jan 20, 2022

im-coder-lg commented Jan 20, 2022

im-coder-lg commented Jan 20, 2022

im-coder-lg commented Jan 20, 2022

sumeshir26 commented Jan 20, 2022

im-coder-lg commented Jan 20, 2022

im-coder-lg left a comment

Choose a reason for hiding this comment

not-nef commented Jan 20, 2022

im-coder-lg commented Jan 25, 2022

im-coder-lg commented Jan 25, 2022

not-nef commented Jan 25, 2022

not-nef commented Jan 12, 2022 •

edited

Loading

netlify bot commented Jan 12, 2022 •

edited

Loading

sumeshir26 commented Jan 13, 2022 •

edited

Loading