Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EvalAnswerMode to HotPotQAEnv #102

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Add EvalAnswerMode to HotPotQAEnv #102

merged 3 commits into from
Oct 30, 2024

Conversation

sidnarayanan
Copy link
Collaborator

  • Adding a configurable EvalAnswerMode
  • Setting default to CONTAINS (previous behavior was equivalent to EXACT)

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Oct 30, 2024
@sidnarayanan @jamesbraza
Update packages/hotpotqa/src/aviary/envs/hotpotqa/env.py
1675000 
Co-authored-by: James Braza <jamesbraza@gmail.com>
jamesbraza
jamesbraza approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@jamesbraza jamesbraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@sidnarayanan sidnarayanan merged commit ed46be4 into main Oct 30, 2024
6 checks passed
@sidnarayanan sidnarayanan deleted the hpqa-eval branch October 30, 2024 22:36
@sidnarayanan sidnarayanan mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesbraza jamesbraza jamesbraza approved these changes

@whitead whitead Awaiting requested review from whitead

@Ryan-Rhys Ryan-Rhys Awaiting requested review from Ryan-Rhys

@albertbou92 albertbou92 Awaiting requested review from albertbou92

Assignees
No one assigned
Labels
enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sidnarayanan @jamesbraza