Fixing sorting of not ordered tool calls

[jamesbraza]

#115 forgot sorting of the not ordered case

[sidnarayanan]

I'd say worth a test, but DummyEnv might be too simple to actually test this. Probably a sign that we need a more complex env for tests (came up in a recent ldp PR too).

[whitead]

Why do non-ordered tool calls need to be sorted? Isn't the point of non-ordered that they aren't in order?

[jamesbraza]

Why do non-ordered tool calls need to be sorted? Isn't the point of non-ordered that they aren't in order?

In exec_tool_calls args, ordered means non-concurrent, and not ordered means concurrent. It's a suboptimal variable name for sure, if you look at the docstring:

        ordered: Opt-in flag for forcing sequential execution (according to order
            in the above message), otherwise tool calls are made concurrently.

I think given tool_calls is a list (and not a set), we generally always care to preserve the sequence