Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved eval_answer from tools to core #142

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Moved eval_answer from tools to core #142

merged 1 commit into from
Dec 6, 2024

Conversation

maykcaldas
Copy link
Collaborator

This PR closes #53 .
I moved eval_answer from tools.utils to aviary.utils.
It can be imported through aviary.core.

@maykcaldas maykcaldas linked an issue Dec 6, 2024 that may be closed by this pull request
Move eval_answer from tools #53
Closed
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 6, 2024
@maykcaldas maykcaldas requested a review from whitead December 6, 2024 01:12
@maykcaldas
Copy link
Collaborator Author

maykcaldas commented Dec 6, 2024 •
edited
Loading

aviary_internal uses this function in two envs, but it imports from core. So I think we're good

jamesbraza
jamesbraza approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@jamesbraza jamesbraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a quick scan it's LGTM

@maykcaldas maykcaldas merged commit 02dc2e2 into main Dec 6, 2024
6 checks passed
@maykcaldas maykcaldas deleted the 53-move-eval_answer-from-tools branch December 6, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesbraza jamesbraza jamesbraza approved these changes

@whitead whitead Awaiting requested review from whitead

Assignees
No one assigned
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move eval_answer from tools
2 participants
@maykcaldas @jamesbraza