minor adjustment to image testing to support png #152
Conversation
ludomitch
requested review from
jamesbraza,
mskarlin,
maykcaldas and
nadolskit
dosubot
bot
added
size:S
There was a problem hiding this comment.
It seems a pre-commit failed because there are commits with different email/username. You can update .mailmap to address that.
Check: https://git-scm.com/docs/gitmailmap
Can you add something like:
Proper Name <proper@email.xx> Commit Name <commit@email.xx>
to the .mailmap file?
EDIT: The error says
The following email addresses are associated with more than one name:
ludo@futurehouse.org
The associations include:
1 Ludovico Mitchener <ludo@futurehouse.org>
1 ludomitch <ludo@futurehouse.org>
Can you try adding:
Ludovico Mitchener <ludo@futurehouse.org> ludomitch
to see if it will solve the issue?
There was a problem hiding this comment.
Isn't the other image stub in this repo basically the same name? Can we give them more verbose names to differentiate between the two easier
There was a problem hiding this comment.
The content of the image isn't as important as the file type. The reason I came across this bug is bc the b64.decode method doesn't treat png prefixed and jpeg prefixed b64 images in the same way so better to test for both. Are you ok if I rename them to sample_jpeg_image.b64 and sample_png_image.b64, respectively?
src/aviary/utils.py
Outdated
| @@ -73,7 +73,9 @@ def encode_image_to_base64(img: "np.ndarray") -> str: | |||
| def check_if_valid_base64(image: str) -> str: | |||
There was a problem hiding this comment.
With this name, I'd expect this function to return a boolean.
Can you change the name to something like validate_base64?
Also, can you make sure the docstring says it returns the image in case it is a valid base64?
No description provided.