Import simplification & dev dependencies #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidnarayanan
requested review from
whitead,
jamesbraza,
Ryan-Rhys and
albertbou92
dosubot
bot
added
the
size:L
jamesbraza
reviewed
Sep 26, 2024
jamesbraza
reviewed
Sep 26, 2024
| "SQLAlchemy[aiosqlite]~=2.0", # Match aviary dependencies | ||
| "aviary.gsm8k[typing]", # So `uv sync` pulls this in, and for type stubs | ||
| "aviary.hotpotqa", # So `uv sync` pulls this in | ||
| "fhaviary[image,llm,server,typing,xml]", |
There was a problem hiding this comment.
Does this actually work (referring to other extras within this extra)?
There was a problem hiding this comment.
Yep - just tested uv pip install -e '.[dev]' on a clean env and all extras were pulled in.
There was a problem hiding this comment.
Also CI is passing, which would need these dependencies
jamesbraza
reviewed
Oct 25, 2024
| "SQLAlchemy[aiosqlite]~=2.0", # Match aviary dependencies | ||
| "aviary.gsm8k[typing]", # So `uv sync` pulls this in, and for type stubs | ||
| "aviary.hotpotqa", # So `uv sync` pulls this in | ||
| "codeflash", |
There was a problem hiding this comment.
Should we remove codeflash from here?
jamesbraza
added a commit
that referenced
this pull request
Oct 26, 2024
jamesbraza
added a commit
that referenced
this pull request
Oct 26, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[dev]extra so that users can dopip install -e '.[dev]'.uv syncshould still work.gsm8kandhotpotqatoaviary.envssubmodulesaviary.coreto organize imports. Note that we cannot auto-import inaviary/__init__.pydue to native namespace packaging.