Fixing ToolSelector handling finish_reason properly
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
requested review from
whitead,
sidnarayanan,
ManvithaPonnapati,
mskarlin,
Ryan-Rhys,
albertbou92 and
nadolskit
dosubot
bot
added
the
size:L
jamesbraza
force-pushed
the
fixing-finish-reason
branch
from
24bc8fb to
4bff08a
Compare
nadolskit
approved these changes
Oct 6, 2024
|
I just made BerriAI/litellm#6091 so we can someday upstream this logic to LiteLLM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://platform.openai.com/docs/guides/function-calling/configuring-function-calling-behavior-using-the-tool_choice-parameter, it turns out if one requires a tool call, the
finish_reasonwill bestopnotrequired(which imo is a bad API set up).This gotcha was not implemented yesterday in #59, but it snuck through here due to our test cassettes. This PR:
finish_reason