Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete the texts #181

Merged
merged 3 commits into from
Mar 7, 2024
Merged

delete the texts #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53d1efb
delete the texts
Dustyposa Aug 11, 2023
0fe94f7
:wrench: remove empty line
Dustyposa Aug 21, 2023
1116a92
Merge branch 'main' into fix_delete
whitead Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions paperqa/docs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,7 @@ def delete(
dockey = doc.dockey
del self.docs[dockey]
self.deleted_dockeys.add(dockey)
self.texts = list(filter(lambda x: x.doc.dockey != dockey, self.texts))

async def adoc_match(
self,
Expand Down
5 changes: 4 additions & 1 deletion tests/test_paperqa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1190,7 +1190,10 @@ def test_dockey_delete():
assert len(keys) == 2
assert len(docs.docs) == 2

docs.delete(docname="test")
docs.delete(dockey="test")
assert len(docs.docs) == 1
assert len(list(filter(lambda x: x.doc.dockey == "test", docs.texts))) == 0

answer = Answer(question="What country was Bates born in?")
assert len(docs.docs) == 1
assert len(docs.deleted_dockeys) == 1
Expand Down
Loading