Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to strip indirect citations #203

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Added option to strip indirect citations #203

merged 4 commits into from
Nov 6, 2023

Conversation

whitead
Copy link
Collaborator

@whitead whitead commented Nov 6, 2023

This enables by default removal of citation markers from summaries that are similar to what is generated in the final response, so that indirect citations (citations that are mentioned in summary) are not propagating up to final answers.

@whitead whitead requested a review from jakublala November 6, 2023 03:40
Co-authored-by: Jakub Lála <68380659+jakublala@users.noreply.github.com>
Copy link
Contributor

@jakublala jakublala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a suggestion to add a comment. Otherwise, good to merge.

This part of the codebase has many sequential parts doing different things, so it'd be great if we comment on specific decisions made in our 'pipeline' design.

@whitead whitead merged commit 1923614 into main Nov 6, 2023
1 check passed
@whitead whitead deleted the indirects branch November 6, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants